This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
Use safe areas and reposition elements on rotation #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jcesarmobile on my iPhone 6+ running iOS 10.3.3 and iPhone 7+ running iOS 11.2.5 I get the following odd behaviour:
So it looks like something is not quite right with those screen sizes. |
|
Improved iPhone X behaviour without breaking other models |
|
This improvement caused a regression, fixed in: #624 |
|
This thread has been automatically locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #583
Used safe areas where available to size and position elements
Moved the code to viewDidAppear as safe area size is not present until then.